Improve ergonomics of gfx_select! #5069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves the ergonomics of
gfx_select!so that the more commonself.<field>expression can be used directly with it.Testing
Compile tested for the platforms I have available, but since this only affects code in the hal layer, that should cover most. I'm not sure how to compile test deno, so I just did the best I could and hopefully CI can try it out for me.
Checklist
cargo fmt.cargo clippy.cargo xtask testto run tests.Internal change, so did not modify
CHANGELOG.md. But will do so if it's still appropriate!