-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pipeline constants plumbing #4730
Conversation
44e86e7
to
a05e269
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bringing in my approval from #4683.
FTR: @crowlKats has previously approved this at #4683 (review). |
Tests in a future MR pretty please 👉🏻👈🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Some minor suggestions.
a05e269
to
f46258e
Compare
Adds pipeline constants plumbing to the
pipeline-constants
feature branch.Tracking meta issue: #4484.
Take 3 (#4677, #4683).