-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename/deprecate block_size -> block_copy_size, improve docs #4647
Conversation
|
Oh didn't notice, thank you! Let's go with that then and link to it ofc. |
actually.. linking it okay. But do we think anyone will ever find |
Technically we are providing the informative value that is described in the spec as
so from that pov we would need to call it block_memory_cost :/ |
moving (potential) discussion to Matrix |
The texel block memory cost is only "informative and non-normative". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Teodor Tanasoaia <[email protected]>
Checklist
cargo clippy
.cargo clippy --target wasm32-unknown-unknown
if applicable.Connections
.bits_per_pixel()
to the TextureFormat to simplify buffer size calculation for each texture format. #4054Description
I keep seeing people getting confused about block_size, so I made its name more explicit and fixed the docs a bit (for instance the link in there was broken)