-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop texture clear_view
s in surface_texture_discard
#4057
Conversation
This does fix the vulkan validation errors but still there is a weird behaviour, with the repro in #4056 if frame skip is triggered more than 3 times (not necessarily consecutive triggers): |
That's because discard isn't implemented: wgpu/wgpu-hal/src/vulkan/instance.rs Line 912 in 50cfc54
|
2f04aee
to
0f710be
Compare
More specifically, I'm not sure there's a meaningful way to implement discard at the hal level - we likely need to keep the image around at the core level and reuse it next time acquire is called. |
Hmm, in that case let's see how much I can grep. |
We can leave that to a follow up if that would be easier |
0f710be
to
91a8406
Compare
Yeah, lets do that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noice
Fixes #4056
Checklist
cargo clippy
.cargo clippy --target wasm32-unknown-unknown
if applicable.Connections
#4056
Description
The texture
clear_view
s weren't destroyed insurface_texture_discard
and that resulted in danglingVkImageView
s.Testing
Tested locally (on Linux) with repro mentioned in #4056