Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress validation error caused by OBS layer #4002

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

cwfitzgerald
Copy link
Member

Checklist

  • Run cargo clippy.
  • Run cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections

Closes #3855
Caused by obsproject/obs-studio#9353

Description

OBS messed up their modification of surface-derived image textures

Testing

Manually

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) August 3, 2023 05:42
@cwfitzgerald cwfitzgerald added the PR: needs back-porting PR with a fix that needs to land on crates label Aug 3, 2023
@cwfitzgerald cwfitzgerald merged commit edd45ff into gfx-rs:trunk Aug 3, 2023
21 checks passed
@jack1232
Copy link

jack1232 commented Aug 3, 2023

Test the suppress-obs-vuid using the latest wgpu (wgpu-hal with Suppress validation error caused by OBS layer (#4002)):

wgpu = { git = "https://github.com/gfx-rs/wgpu.git" }

on Windows 11, Nvidia RTX 3060 with Vulkan backend. Still got a validation error:

VUID-VkInstanceCreateInfo-flags-zerobitmask(ERROR / SPEC): msgNum: 1636402386 - Validation Error: [ VUID-VkInstanceCreateInfo-flags-zerobitmask ] Object 0: VK_NULL_HANDLE, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x618984d2 | vkCreateInstance: parameter pCreateInfo->flags must be 0. The Vulkan spec states: flags must be 0 (https://vulkan.lunarg.com/doc/view/1.3.204.1/windows/1.3-extensions/vkspec.html#VUID-VkInstanceCreateInfo-flags-zerobitmask)

However, this error only occurs once, but not on every frame, which is different from the previous error that is logged every frame.

The app runs fine, but this error is still very annoying.

@cwfitzgerald
Copy link
Member Author

This is a different problem that was being hidden by the other one. This is our issue, I believe.

@jack1232
Copy link

jack1232 commented Aug 3, 2023

I also think this is a different issue. But it is still annoying...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imageless Swapchain Vulkan Validation Error
2 participants