Validate that BufferDescriptor::usage is not zero #3928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nical
changed the title
|
Nit on OP title: s/BufferDesctor/BufferDescriptor |
ErichDonGubler
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
Pretty easy to validate this against the spec.:
5.1.3. Buffer Creation
createBuffer(descriptor)…
Device timeline initialization steps:
- If any of the following requirements are unmet, generate a validation error, make bi invalid, and stop.
…
descriptor.usagemust not be 0.
LGTM!; Note, though, that I don't have approving or merging rights, so…😅🤷🏻♂️
nical
changed the title
jimblandy
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
Let's get that Cargo.lock change out of there. Otherwise, looks good.
@ErichDonGubler Thanks for checking the spec.
Annoyingly rust-analyzer always instantly puts it back by building its thing |
|
@nical: `git add -p` FTW!
|
nical
force-pushed
the
create-buf-usage-zero
branch
from
915b4ef
to
8002404
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.Connections
Found this while investigating CTS failures in Firefox.
Description
WebGPU's spec says that descriptor.usage must not be 0. The vulkan spec as well, in fact it's the validation layer that helped me notice.
Testing
It's covered by the CTS run by Firefox, so I got lazy and did not produce a test. Let me know if you want a test here as well.