Make initialize_adapter_from_env take a compatible surface #3905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a compatible surface parameter to initialize_adapter_from_env, and use that to make initialize_adapter_from_env_or_default always respect its compatible_surface parameter.
cwfitzgerald
previously requested changes
Jul 7, 2023
Wumpf
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Similar issue as in #3792, initialize_adapter_from_env_or_default ignores backend_bits if WGPU_ADAPTER_NAME is not set
Description
The
initialize_adapter_from_env_or_defaultfunction currently does not respect thecompatible_surfaceparameter ifWGPU_ADAPTER_NAMEis set, andinitialize_adapter_from_envcannot be used with a compatible surface requirement.Let's modify
initialize_adapter_from_envto take acompatible_surface: Option<&Surface>parameter, and makeinitialize_adapter_from_env_or_defaultuse that.Testing
Manual testing in separate project.