Add Extended Examples #3885
Merged
Add Extended Examples #3885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a1phyr
reviewed
Jun 23, 2023
Co-authored-by: Alphyr <[email protected]>
… be changed to work for wasm. [no ci]
Merge branch 'JustAnotherCodemonkey/add-examples' of github.com:JustAnotherCodemonkey/wgpu into JustAnotherCodemonkey/add-examples
|
Re-drafting since I decided to add at least one more example for compute workgroups. |
JustAnotherCodemonkey
force-pushed
the
JustAnotherCodemonkey/add-examples
branch
from
52e9a6f
to
a15fc4a
Compare
…ures to the table to accurately represent the examples.\n\nFor the new features, not all old examples may be fully represented.
…examples as well as hints on how examples build off of each other.
cwfitzgerald
changed the title
|
@jimblandy @teoxoy @nical could someone from moz-land take a look at this, I've done a solid first pass on it and the PR is strong, but am really struggling to find the bandwidth to do a second pass. |
nical
reviewed
Sep 20, 2023
…o-texture to make it more clear.
…ut staging buffer.
…struct to the input WGSL buffer.
…ecessary (portability to WASM).
…struct using POD to be more clear.
|
@cwfitzgerald Since I updated the README, do you think you could lift the change requested that was regarding the README? |
nical
approved these changes
Oct 2, 2023
|
Just need conflicts fixed and we can land! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.cargo clippy --target wasm32-unknown-unknownif applicable.Description
Add examples, especially regarding wgpu for GPGPU.
Testing
(Most of these I don't really know how to test. I guess the testing method is running it and seeing if what goes to screen / fs is the same as what was advertised.)