-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't report violations of VUID-vkCmdEndDebugUtilsLabelEXT-commandBuffer-01912 #3809
Conversation
88ac91f
to
d37753a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Layer properties in KhronosGroup/Vulkan-ValidationLayers@a90644606 (after introduction of 01912 test):
|
Layer properties in KhronosGroup/Vulkan-ValidationLayers@a54744d67 (current main):
|
270c3fa
to
4e2bd46
Compare
Okay, this version of the PR supplies the validation layer description and version to the debug utils messenger callback, and checks them to ensure that we're only filtering out errors from affected versions of But I think it does violence to the API of |
4e2bd46
to
6c46605
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great to get this in as #3830 is now hitting it.
6c46605
to
485c4b8
Compare
…fer-01912 As described in [Vulkan-ValidationLayers#5671], the validation layers don't understand debug ranges paired across different command buffers on the same queue, even though the Vulkan spec says: > An application may open a debug label region in one command buffer and close it in another, or otherwise split debug label regions across multiple command buffers or multiple queue submissions. When viewed from the linear series of submissions to a single queue, the calls to vkCmdBeginDebugUtilsLabelEXT and vkCmdEndDebugUtilsLabelEXT must be matched and balanced. Until this is fixed, wgpu should ignore this validation error to reduce noise in test runs. Fixes gfx-rs#3733. [Vulkan-ValidationLayers#5671]: KhronosGroup/Vulkan-ValidationLayers#5671
485c4b8
to
220d58b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
As described in Vulkan-ValidationLayers#5671, the validation layers don't understand debug ranges paired across different command buffers on the same queue, even though the Vulkan spec says:
Until this is fixed, wgpu should ignore this validation error to reduce noise in test runs.
Fixes #3733.
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.