Backport bugfixes to v0.16 #3774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this one should also go in here #3744 |
|
I also merged in this fix: |
* Always support 4x MSAA on GL * Update changelog
cwfitzgerald
approved these changes
May 25, 2023
| @@ -697,7 +697,7 @@ pub enum BindError { | |||
| s1 = if *.actual >= 2 { "s" } else { "" }, | |||
| )] | |||
| MismatchedDynamicOffsetCount { | |||
| group: u8, | |||
| group: u32, | |||
There was a problem hiding this comment.
Oi, this is, technically, a semver breaking change.
I think we could validly argue that while it is breaking, no one is going to be looking at it, only calling Display::fmt.
Let's go ahead with it.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Description
Backports
u32indices for bind group layouts everywhere #3743all of which are crash fixes without any apparent api breackage.
Testing
It compiles and the only thing conflicting was the changelog