Document that various sizes and offsets are in bytes. #3773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document that the following are in bytes: - `BindingType::Buffer::min_binding_size` - `BufferBinding::offset` - `BufferBinding::size` - `BufferDescriptor::size` Clarify other requirements as well. Fixes gfx-rs#3768.
jimblandy
force-pushed
the
document-alignment-by-byte-wgpu-3768
branch
from
f85e8d9
to
54377ed
Compare
cwfitzgerald
added
the
PR: needs back-porting
cwfitzgerald
approved these changes
May 14, 2023
cwfitzgerald
removed
the
PR: needs back-porting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document that the following are in bytes:
BindingType::Buffer::min_binding_sizeBufferBinding::offsetBufferBinding::sizeBufferDescriptor::sizeClarify other requirements as well.
Fixes #3768.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.