Web: handle None for depth_ops and stencil_ops #3660
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
There's no corresponding issue yet (should I create one?).
More or less depends on #3657 (at least to see the result), here's a branch merging both fixes for testing: https://github.com/niklaskorz/wgpu/tree/dynamic-dispatch-depth-fix
Description
Describe what problem this is solving, and how it's solved.
When using a
DepthStencilState
with a texture that only includes depth but not stencil data (e.g.,TextureFormat::Depth32Float
instead ofTextureFormat::Depth24PlusStencil8
), and then specifyingstencil_ops: None
in theRenderPassDepthStencilAttachment
, Chrome Beta 113 reports the following:This is fixed by not defining any stencil parameters on the
web_sys::GpuRenderPassDepthStencilAttachment
whenstencil_ops
is None.Testing
Explain how this change is tested.
Tested on my project https://github.com/niklaskorz/linon using Chrome Beta 113 (see branch
dynamic-dispatch-workaround
, deployed on https://niklaskorz.github.io/linon/).