Properly drop surfaces #3647
Merged
Properly drop surfaces #3647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminSchaaf
force-pushed
the
drop-surface
branch
from
cb4d9c0
to
44e06ae
Compare
Surfaces weren't being dropped until exit due to the code commented out in Context::surface_drop. This hid a bug where surfaces dropped before exit weren't being unconfigured. Fixes gfx-rs#3646
BenjaminSchaaf
force-pushed
the
drop-surface
branch
from
44e06ae
to
b8d820d
Compare
cwfitzgerald
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Fixes #3646
Description
Surfaces weren't being dropped until exit due to the code commented out in Context::surface_drop. This hid a bug where surfaces dropped before exit weren't being unconfigured.
Testing
I ran some of the examples as well as the example from the issue and they worked as expected.