Implement clear_buffer on web
#3426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was "TODO" but would be very nice to have.
cwfitzgerald
added
the
PR: needs back-porting
cwfitzgerald
pushed a commit
that referenced
this pull request
Feb 9, 2023
cwfitzgerald
removed
the
PR: needs back-porting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was "TODO" but would be very nice to have.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
There's a workaround for this in linebender/vello#267
Description
The
clear_buffer()method is an empty TODO on the web back-end. This patch fills in the obvious implementation.Testing
It's not carefully tested just yet, but we do plan to soon. Necessary steps will be landing vello#267, updating vello to wgpu 0.15 (vello#263 is the PR in progress for that), removing the hacky workaround, and verifying that it works in Chrome Canary.