Don't panic when gl.create_buffer() fails on webgl #3396
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Connections
n/a
Description
In webgl
gl.create_buffer()
is fallible, and can return null (or Err, thanks to glow) when the device is unable to allocate any more buffers. We unwrap and crash instead of treating it as we do other OOM cases.Side note: Has there been a discussion already about potentially disallowing
unwrap()
going forwards? So many unwraps are quite fragile :(expect
forces developers to give a reason to why the panic should never happen.Testing
Passes existing tests.