Add validation in accordance with WebGPU GPUSamplerDescriptor
valid…
#3353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… usage for
lodMinClamp
andlodMaxClamp
.lodMinClamp
must not be negative, andlodMaxClamp
must be >=lodMinClamp
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Done just in case, with
--feature gles
.Description
For
wgpu::SamplerDescriptor
, it was possible to use values forlod_min_clamp
andlod_max_clamp
such that:lod_min_clamp
is negativelod_max_clamp
<lod_min_clamp
both of which are in violation of the valid usage defined for
GPUSamplerDescriptor
in the WebGPU spec:This PR adds
InvalidLodClamp
toCreateSamplerError
, inspired by the already-existingInvalidClamp
, and uses that if the validation fails.Testing
Tested locally.