Don't use a callback to return backend instance handles. #2991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
force-pushed
the
as_hal_no_callback
branch
from
ec44db1
to
ee7f1e0
Compare
cwfitzgerald
approved these changes
Aug 28, 2022
Change `Instance::as_hal<A>` to simply return an `Option<&A::Instance>`, rather than passing it to a callback. We're just borrowing a reference to some `wgpu_hal::Api::Instance` owned by the `wgpu_core::instance::Instance`, so there's no special scoping or locking magic required here.
jimblandy
force-pushed
the
as_hal_no_callback
branch
from
ee7f1e0
to
bedc919
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Instance::as_hal<A>to simply return anOption<&A::Instance>, rather than passing it to a callback. We'rejust borrowing a reference to some
wgpu_hal::Api::Instanceowned bythe
wgpu_core::instance::Instance, so there's no special scoping orlocking magic required here.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
Description
Describe what problem this is solving, and how it's solved.
Testing
Explain how this change is tested.