Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure the BufferMapCallback is always called. #2848

Merged
merged 2 commits into from
Jul 8, 2022
Merged

Ensure the BufferMapCallback is always called. #2848

merged 2 commits into from
Jul 8, 2022

Commits on Jul 7, 2022

  1. Ensure the BufferMapAsyncCallback is always called. 

    This solves two issues on the Gecko side:
 - The callback cleans up after itself (the user data is deleted at the end of the callback), so dropping the callback without calling it is a memory leak. I can't think of a better way to implement this on the C++ side since there can be any number of callback at any time living for an unspecified amount of time.
 - This makes it easier to implement the error reporting of the WebGPU spec.
    @nical
    nical committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    75e0a24 View commit details
    Browse the repository at this point in the history

  2. Update the changelog.

    @nical
    nical committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    d8565c9 View commit details
    Browse the repository at this point in the history