Implement submission indexes #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
force-pushed
the
submission-indexes
branch
from
3195eeb
to
42b21e9
Compare
cwfitzgerald
force-pushed
the
submission-indexes
branch
2 times, most recently
from
e94df11
to
862e59c
Compare
cwfitzgerald
force-pushed
the
submission-indexes
branch
from
862e59c
to
b7178b8
Compare
jimblandy
approved these changes
May 31, 2022
Co-authored-by: Jim Blandy <[email protected]>
cwfitzgerald
force-pushed
the
submission-indexes
branch
from
cb92cc6
to
9894497
Compare
cwfitzgerald
force-pushed
the
submission-indexes
branch
from
ce3442b
to
f6b391b
Compare
cwfitzgerald
force-pushed
the
submission-indexes
branch
from
f6b391b
to
ebf9bcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Connected with #2698 and our whole backpressure story.
Description
This implements submission indexes so that compute workloads can properly implement backpressure.
I also found issues with our lifetime management, which is why every unit test I wrote is skipped. We are dropping the buffer immediately after the submission instead of properly waiting for it to finish gpu side execution. I tested these unit tests back before the tracker rewrite, so the tracker rewrite isn't at fault.
Testing
It has tests!