Adapter and Instance as_hal functions #2663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
requested changes
May 17, 2022
i509VCB
force-pushed
the
hal/more-internals
branch
from
e43690f
to
3b0c509
Compare
cwfitzgerald
requested changes
May 17, 2022
These functions are added to allow lower level access to adapter and instance from backends.
i509VCB
force-pushed
the
hal/more-internals
branch
from
3b0c509
to
ad52fca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment the inner hal type for Instance and Adapter are not possible to access. This adds
as_halfunctions to Instance and Adapter.HalApi does gain a new function (
instance_as_hal) to implementas_halfor Instance without resorting to aInstance::as_(backend)function for every backend.