Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move texture-array example over to wgsl #2618

Merged
merged 10 commits into from
Apr 25, 2022

Conversation

cwfitzgerald
Copy link
Member

@cwfitzgerald cwfitzgerald commented Apr 20, 2022

Connections

Closes #2613
Closes #2287

Depends on gfx-rs/naga#1855 but reviewable as is.

Description

Finally! Native support for binding indexing in vulkan, dx12, and metal!

Testing

Mainly through the texture-array example, more to come.

@cwfitzgerald cwfitzgerald requested a review from kvark April 20, 2022 06:08
@SetheenDev
Copy link

Very excited for this! Seems related to gpuweb/gpuweb#822

@cwfitzgerald
Copy link
Member Author

Yup! Once various parts of this project are finished, I'm going too bring my learnings up to that issue.

Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update the table in the examples README, please!

wgpu-hal/src/dx12/device.rs Outdated Show resolved Hide resolved
wgpu-types/src/lib.rs Show resolved Hide resolved
@cwfitzgerald cwfitzgerald enabled auto-merge (squash) April 25, 2022 18:21
@cwfitzgerald cwfitzgerald merged commit e54a36e into gfx-rs:master Apr 25, 2022
@cwfitzgerald cwfitzgerald deleted the wgsl-binding-indexing branch April 25, 2022 18:37
@SetheenDev
Copy link

@cwfitzgerald , I tried this out and it completely resolved my hardware debug issue and replaced my ugly glsl->spirv shader flow with clean wgsl. Thank you for adding binding_array!

@cwfitzgerald
Copy link
Member Author

Glad to hear it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants