metal: fix some supported limits #2608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
approved these changes
Apr 19, 2022
kvark
added
the
PR: needs back-porting
cwfitzgerald
removed
the
PR: needs back-porting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed
max_inter_stage_shader_componentsaccording to the Metal feature set table and the implementation of WebKit:https://github.com/WebKit/WebKit/blob/a438d3bb8e5cc0fa8fde2b9707fd446f0e0ed539/Source/WebGPU/WebGPU/HardwareLimits.mm#L99
Fixed
max_compute_workgroup_storage_size:https://github.com/WebKit/WebKit/blob/a438d3bb8e5cc0fa8fde2b9707fd446f0e0ed539/Source/WebGPU/WebGPU/HardwareLimits.mm#L66
Fixed
max_compute_workgroup_size_xxTesting
Tested on M1 Mac and iPhone 12, none of the wgpu samples were broken.