Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symlink LICENSE files into crates. #2604

Merged
merged 2 commits into from
May 29, 2022

Conversation

dskkato
Copy link
Contributor

@dskkato dskkato commented Apr 17, 2022

Symlink the top-level LICENSE into each published crate.

This will resolve #2561

Symlink the top-level LICENSE into each published crates.
@dskkato
Copy link
Contributor Author

dskkato commented Apr 17, 2022

I don't think it is appropriate for me to send this PR since I am not a party to this issue, so I will close this. If this correction looks good, please reopen.

@dskkato dskkato closed this Apr 17, 2022
@kvark
Copy link
Member

kvark commented Apr 18, 2022

We should only put it in the sub-crates where it's required (and which are published). As such, I don't think we want to modify deno_webgpu and wgpu-info with these.

@kvark kvark reopened this Apr 18, 2022
Since deno_webgpu and wgpu-info are not dependency of wgpu.
@cwfitzgerald
Copy link
Member

I don't think the symlink thing ended up working considering the dffs

@dskkato
Copy link
Contributor Author

dskkato commented Apr 18, 2022

I don't think the symlink thing ended up working considering the dffs

Is it better to put actual copies to those subdirectory? Currently, I'm just naively trying to follow the case of prost.

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, if that works for them, that's fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LICENSE files in package subdirs
3 participants