-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make PresentMode
configurable.
#245
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash, address my comment, and update the examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing the concerns!
Where did wgpu.h go?
The
Well I can't build the C examples as of now still ... I just made an intermediate commit as it builds for Rust only. |
828d870
to
df46e3e
Compare
Disable vsync Revert accidential hardcode of num_frames Make the PresentMode configurable Adapt examples + adjust style according to @kvrak Adher to @kvarks wishes for style. Examples build. Fix unnecessary ampersand.
bors r+ |
245: Make `PresentMode` configurable. r=kvark a=Yatekii Co-authored-by: Noah Hüsser <[email protected]>
33: Make `PresentMode` configurable. r=kvark a=Yatekii See: gfx-rs/wgpu#245 Co-authored-by: Noah Hüsser <[email protected]>
Build failed |
bors try |
tryBuild succeeded |
Bors r+
… On Jul 16, 2019, at 19:41, bors[bot] ***@***.***> wrote:
try
Build succeeded
continuous-integration/travis-ci/push
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
245: Make `PresentMode` configurable. r=kvark a=Yatekii Co-authored-by: Noah Hüsser <[email protected]>
Build succeeded |
33: Make `PresentMode` configurable. r=kvark a=Yatekii See: gfx-rs/wgpu#245 Co-authored-by: Noah Hüsser <[email protected]>
33: Make `PresentMode` configurable. r=kvark a=Yatekii See: gfx-rs#245 Co-authored-by: Noah Hüsser <[email protected]>
245: Check `cargo doc` in CI r=kvark a=hecrj This PR makes CI run `cargo doc` using the latest nightly. It is currently panicking here: https://github.com/rust-lang/rust/blob/6dee5f1126dfd5c9314ee5ae9d9eb010e35ef257/src/librustdoc/passes/mod.rs#L411 I thought it was an incorrect link causing it, but the issue seems to persist even after fixing the link. __Update__: Issue opened upstream by @grovesNL (rust-lang/rust#70874). Co-authored-by: Héctor Ramón Jiménez <[email protected]>
No description provided.