Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PresentMode configurable. #245

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Make PresentMode configurable. #245

merged 1 commit into from
Jul 17, 2019

Conversation

Yatekii
Copy link
Contributor

@Yatekii Yatekii commented Jul 5, 2019

No description provided.

Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash, address my comment, and update the examples.

wgpu-native/src/device.rs Outdated Show resolved Hide resolved
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing the concerns!
Where did wgpu.h go?

wgpu-native/src/swap_chain.rs Outdated Show resolved Hide resolved
wgpu-native/src/device.rs Outdated Show resolved Hide resolved
@Yatekii
Copy link
Contributor Author

Yatekii commented Jul 5, 2019

The

Thank you for addressing the concerns!
Where did wgpu.h go?

Well I can't build the C examples as of now still ... I just made an intermediate commit as it builds for Rust only.
Dunno how to fix it.
But ofc that gets pushed to the PR.

wgpu-native/src/device.rs Outdated Show resolved Hide resolved
@Yatekii Yatekii force-pushed the master branch 2 times, most recently from 828d870 to df46e3e Compare July 11, 2019 16:39
Disable vsync

Revert accidential hardcode of num_frames

Make the PresentMode configurable

Adapt examples
+ adjust style according to @kvrak

Adher to @kvarks wishes for style.

Examples build.

Fix unnecessary ampersand.
@kvark
Copy link
Member

kvark commented Jul 11, 2019

bors r+

bors bot added a commit that referenced this pull request Jul 11, 2019
245: Make `PresentMode` configurable. r=kvark a=Yatekii



Co-authored-by: Noah Hüsser <[email protected]>
bors bot added a commit to gfx-rs/wgpu-rs that referenced this pull request Jul 11, 2019
33: Make `PresentMode` configurable. r=kvark a=Yatekii

See: gfx-rs/wgpu#245

Co-authored-by: Noah Hüsser <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jul 11, 2019

Build failed

@kvark
Copy link
Member

kvark commented Jul 16, 2019

bors try

bors bot added a commit that referenced this pull request Jul 16, 2019
@bors
Copy link
Contributor

bors bot commented Jul 16, 2019

try

Build succeeded

@kvark
Copy link
Member

kvark commented Jul 17, 2019 via email

bors bot added a commit that referenced this pull request Jul 17, 2019
245: Make `PresentMode` configurable. r=kvark a=Yatekii



Co-authored-by: Noah Hüsser <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jul 17, 2019

Build succeeded

@bors bors bot merged commit c5c7092 into gfx-rs:master Jul 17, 2019
bors bot added a commit to gfx-rs/wgpu-rs that referenced this pull request Jul 17, 2019
33: Make `PresentMode` configurable. r=kvark a=Yatekii

See: gfx-rs/wgpu#245

Co-authored-by: Noah Hüsser <[email protected]>
kvark pushed a commit to kvark/wgpu that referenced this pull request Jun 3, 2021
33: Make `PresentMode` configurable. r=kvark a=Yatekii

See: gfx-rs#245

Co-authored-by: Noah Hüsser <[email protected]>
kvark pushed a commit to kvark/wgpu that referenced this pull request Jun 3, 2021
245: Check `cargo doc` in CI r=kvark a=hecrj

This PR makes CI run `cargo doc` using the latest nightly.

It is currently panicking here:

https://github.com/rust-lang/rust/blob/6dee5f1126dfd5c9314ee5ae9d9eb010e35ef257/src/librustdoc/passes/mod.rs#L411

I thought it was an incorrect link causing it, but the issue seems to persist even after fixing the link.

__Update__: Issue opened upstream by @grovesNL (rust-lang/rust#70874).

Co-authored-by: Héctor Ramón Jiménez <[email protected]>
Patryk27 pushed a commit to Patryk27/wgpu that referenced this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants