Identify Apple M1 GPU as integrated #2429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
requested changes
Jan 28, 2022
Fall back to current low_power implies integrated GPU for older OSes.
kvark
approved these changes
Jan 28, 2022
|
This isn't how I saw this being done, but it's good. Maybe even better than I wanted :) |
kvark
added
the
PR: needs back-porting
cwfitzgerald
removed
the
PR: needs back-porting
cwfitzgerald
pushed a commit
that referenced
this pull request
Oct 25, 2023
* Properly test `-Zminimal-versions` * Fix minimal version requirement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Description
The Apple M1 line of GPUs use a unified memory architecture that implies they are integrated but wgpu currently uses whether they are low power (Metal backend), or name-based heuristics (GL backend) which classify them as discrete, which seems incorrect.
Testing
I ran a few native examples (so only tested the Metal backend) and checked the adapter info to see that it had changed to
IntegratedGpu.