Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wgsl-in] Handle repeated or missing @workgroup_size #2435

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

fornwall
Copy link
Contributor

@fornwall fornwall commented Aug 13, 2023

Fixes #2271 and also fixes #2434.

@fornwall
Copy link
Contributor Author

fornwall commented Aug 13, 2023

Change for missing @workgroup_size (#2271):

With the below shader:

@compute
fn main() {}

Before:
Screenshot 2023-08-14 at 01 22 55

After:
Screenshot 2023-08-14 at 01 31 10

@fornwall
Copy link
Contributor Author

Change for repeated @workgroup_size (#2434):

For the below shader:

@compute @workgroup_size(1) @workgroup_size(1)
fn main() {}

Before:
Screenshot 2023-08-14 at 01 28 19

After:
Screenshot 2023-08-14 at 01 27 40

Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a bigger question if we should make it optional at the IR level but this looks good for now.

Thanks for the recent contributions! :)

@teoxoy teoxoy merged commit f6e99a4 into gfx-rs:master Aug 17, 2023
6 checks passed
@fornwall fornwall deleted the validate-workgroup-size branch August 17, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants