[glsl-in] Refactors #2418
Merged
[glsl-in] Refactors #2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
reviewed
Aug 3, 2023
jimblandy
force-pushed
the
glsl-refactors
branch
from
2f6c837
to
a017e27
Compare
|
Pushed fixes for the comments I made earlier. |
jimblandy
force-pushed
the
glsl-refactors
branch
from
a017e27
to
5f0bf9f
Compare
|
Slight reordering of commits, because I'd like to not squash this. |
jimblandy
force-pushed
the
glsl-refactors
branch
from
5f0bf9f
to
6429a67
Compare
|
Rebased on 5329aa2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors needed for #2309.