-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wgsl-in] Split into multiple files #2207
Conversation
This looks great, but let's fix those doc links. |
Oops, missed that. Rustdoc seems to be acting weird, however. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, just some minor points.
Acknowledging Teo's suggestion in #2075 that all the front ends should use Frontend
instead of Parser
, I have to say I would also approve a PR that just left GLSL alone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just minor comments.
I don't know how @JCapucho is going to feel about the GLSL changes. If he's not happy with them, we can back them out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thanks!
f599c67
to
7077562
Compare
Clippy got clevererer. |
Filed #2229 for the Clippy problems. |
7077562
to
38f29c9
Compare
rebased on merged #2229 |
In #2075, we left all the changes in one file to make reviewing easier. However, this made
front/wgsl/mod.rs
huge (5,447 lines), and quite challenging to follow.This PR splits each pass into its own module, bringing both
parse/mod.rs
andlower/mod.rs
to a more manageable ~2,000 lines. Other thanuse
s, everything has been copy-pasted.Since the frontends now do more than parse, I also renamed them to
Frontend
instead ofParser
to make the intent more clear: #2075 (comment)