Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bitflags to v2 #269

Merged
merged 1 commit into from
May 31, 2023
Merged

Bump bitflags to v2 #269

merged 1 commit into from
May 31, 2023

Conversation

daxpedda
Copy link
Contributor

Changelog: https://github.com/bitflags/bitflags/blob/2.0.0/CHANGELOG.md#200.

This is a breaking change. The API that is implemented by the macro is now different.

I was a bit liberal with deriving std traits on public types, which mimics the behavior of bitflags v1, let me know if we don't need all these traits. Potentially we could at least drop PartialOrd and Ord.

Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@daxpedda
Copy link
Contributor Author

CI is broken with the same error as on master.

@kvark kvark merged commit ca33614 into gfx-rs:master May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants