fix metal build #2379
Merged
fix metal build #2379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartcarnie
force-pushed
the
sgc-build-fix
branch
from
99bae45 to
63fc9a8
Compare
|
Thank you for the fix! Does it work on Xcode9 toolchain? |
|
@kvark yes, was using Xcode |
grovesNL
approved these changes
Sep 5, 2018
There was a problem hiding this comment.
Thanks! I also confirmed this works with Xcode 9.4.1, and -c is known to fix gfx-rs/portability#159 too, so I think we should proceed with this.
bors r+
bors bot
added a commit
that referenced
this pull request
Sep 5, 2018
2379: fix metal build r=grovesNL a=stuartcarnie
Fixes metal compilation issue:
metallib: Invalid bitcode file!
PR checklist:
- [ ] `make` succeeds (on *nix)
- a few failures due to rust-lang/rust#52801
- [x] `make reftests` succeeds
- [x] tested examples with the following backends: **metal**
- [x] `rustfmt` run on changed code
Co-authored-by: Stuart Carnie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes metal compilation issue:
PR checklist:
makesucceeds (on *nix)make reftestssucceedsrustfmtrun on changed code