-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatible with contextvars.ContextVar #1407
Labels
Milestone
Comments
Any idea when this might get done, or guidance you can provide on the implementation? |
I've been heads down on another project, but I'm hoping to have more time for gevent next month. |
Any news on this? |
Just want to check in again, any update or guidance you can give so someone else could take it on? |
mauriciovasquezbernal
added a commit
to kinvolk/opentelemetry-python
that referenced
this issue
Nov 7, 2019
This commit ports the OpenTracing testbed[1] to check that the ot-shim is working as expected using different frameworks. Gevent doesn't support context vars yet[2], so those tests are not compatible with opentelemetry and were not ported. [1] https://github.com/opentracing/opentracing-python/tree/master/testbed [2] gevent/gevent#1407
mauriciovasquezbernal
added a commit
to kinvolk/opentelemetry-python
that referenced
this issue
Nov 7, 2019
This commit ports the OpenTracing testbed[1] to check that the ot-shim is working as expected using different frameworks. Gevent doesn't support context vars yet[2], so those tests are not compatible with opentelemetry and were not ported. [1] https://github.com/opentracing/opentracing-python/tree/master/testbed [2] gevent/gevent#1407
mauriciovasquezbernal
added a commit
to kinvolk/opentelemetry-python
that referenced
this issue
Nov 7, 2019
This commit ports the OpenTracing testbed[1] to check that the ot-shim is working as expected using different frameworks. Gevent doesn't support context vars yet[2], so those tests are not compatible with opentelemetry and were not ported. [1] https://github.com/opentracing/opentracing-python/tree/master/testbed [2] gevent/gevent#1407
mauriciovasquezbernal
added a commit
to kinvolk/opentelemetry-python
that referenced
this issue
Nov 7, 2019
This commit ports the OpenTracing testbed[1] to check that the ot-shim is working as expected using different frameworks. Gevent doesn't support context vars yet[2], so those tests are not compatible with opentelemetry and were not ported. [1] https://github.com/opentracing/opentracing-python/tree/master/testbed [2] gevent/gevent#1407
mauriciovasquezbernal
added a commit
to kinvolk/opentelemetry-python
that referenced
this issue
Nov 13, 2019
This commit ports the OpenTracing testbed[1] to check that the ot-shim is working as expected using different frameworks. Gevent doesn't support context vars yet[2], so those tests are not compatible with opentelemetry and were not ported. [1] https://github.com/opentracing/opentracing-python/tree/master/testbed [2] gevent/gevent#1407
mauriciovasquezbernal
added a commit
to open-telemetry/opentelemetry-python
that referenced
this issue
Jan 15, 2020
This commit ports the OpenTracing testbed[1] to check that the ot-shim is working as expected using different frameworks. Gevent doesn't support context vars yet[2], so those tests are not compatible with opentelemetry and were not ported. [1] https://github.com/opentracing/opentracing-python/tree/master/testbed [2] gevent/gevent#1407
jamadden
added a commit
that referenced
this issue
Jan 15, 2020
These are greenlet local. Fixes #1407
jamadden
added
Status: in progress
Type: Enhancement
We can do better through adding this
labels
Jan 15, 2020
toumorokoshi
added a commit
to open-telemetry/opentelemetry-python
that referenced
this issue
Jun 3, 2020
This commit ports the OpenTracing testbed[1] to check that the ot-shim is working as expected using different frameworks. Gevent doesn't support context vars yet[2], so those tests are not compatible with opentelemetry and were not ported. [1] https://github.com/opentracing/opentracing-python/tree/master/testbed [2] gevent/gevent#1407 Co-authored-by: Mauricio Vásquez <[email protected]> Co-authored-by: alrex <[email protected]>
toumorokoshi
added a commit
to toumorokoshi/opentelemetry-python
that referenced
this issue
Jun 5, 2020
This commit ports the OpenTracing testbed[1] to check that the ot-shim is working as expected using different frameworks. Gevent doesn't support context vars yet[2], so those tests are not compatible with opentelemetry and were not ported. [1] https://github.com/opentracing/opentracing-python/tree/master/testbed [2] gevent/gevent#1407 Co-authored-by: Mauricio Vásquez <[email protected]> Co-authored-by: alrex <[email protected]>
sethmaxwl
pushed a commit
to sethmaxwl/opentelemetry-python
that referenced
this issue
Jun 5, 2020
This commit ports the OpenTracing testbed[1] to check that the ot-shim is working as expected using different frameworks. Gevent doesn't support context vars yet[2], so those tests are not compatible with opentelemetry and were not ported. [1] https://github.com/opentracing/opentracing-python/tree/master/testbed [2] gevent/gevent#1407 Co-authored-by: Mauricio Vásquez <[email protected]> Co-authored-by: alrex <[email protected]>
NathanielRN
pushed a commit
to NathanielRN/opentelemetry-python-contrib-1
that referenced
this issue
Oct 20, 2020
This commit ports the OpenTracing testbed[1] to check that the ot-shim is working as expected using different frameworks. Gevent doesn't support context vars yet[2], so those tests are not compatible with opentelemetry and were not ported. [1] https://github.com/opentracing/opentracing-python/tree/master/testbed [2] gevent/gevent#1407 Co-authored-by: Mauricio Vásquez <[email protected]> Co-authored-by: alrex <[email protected]>
NathanielRN
pushed a commit
to NathanielRN/opentelemetry-python-contrib-1
that referenced
this issue
Oct 20, 2020
This commit ports the OpenTracing testbed[1] to check that the ot-shim is working as expected using different frameworks. Gevent doesn't support context vars yet[2], so those tests are not compatible with opentelemetry and were not ported. [1] https://github.com/opentracing/opentracing-python/tree/master/testbed [2] gevent/gevent#1407 Co-authored-by: Mauricio Vásquez <[email protected]> Co-authored-by: alrex <[email protected]>
NathanielRN
pushed a commit
to NathanielRN/opentelemetry-python-contrib-1
that referenced
this issue
Oct 24, 2020
This commit ports the OpenTracing testbed[1] to check that the ot-shim is working as expected using different frameworks. Gevent doesn't support context vars yet[2], so those tests are not compatible with opentelemetry and were not ported. [1] https://github.com/opentracing/opentracing-python/tree/master/testbed [2] gevent/gevent#1407 Co-authored-by: Mauricio Vásquez <[email protected]> Co-authored-by: alrex <[email protected]>
NathanielRN
pushed a commit
to NathanielRN/opentelemetry-python-contrib-1
that referenced
this issue
Nov 2, 2020
This commit ports the OpenTracing testbed[1] to check that the ot-shim is working as expected using different frameworks. Gevent doesn't support context vars yet[2], so those tests are not compatible with opentelemetry and were not ported. [1] https://github.com/opentracing/opentracing-python/tree/master/testbed [2] gevent/gevent#1407 Co-authored-by: Mauricio Vásquez <[email protected]> Co-authored-by: alrex <[email protected]>
NathanielRN
pushed a commit
to NathanielRN/opentelemetry-python-contrib-1
that referenced
this issue
Nov 2, 2020
This commit ports the OpenTracing testbed[1] to check that the ot-shim is working as expected using different frameworks. Gevent doesn't support context vars yet[2], so those tests are not compatible with opentelemetry and were not ported. [1] https://github.com/opentracing/opentracing-python/tree/master/testbed [2] gevent/gevent#1407 Co-authored-by: Mauricio Vásquez <[email protected]> Co-authored-by: alrex <[email protected]>
NathanielRN
pushed a commit
to NathanielRN/opentelemetry-python-contrib-1
that referenced
this issue
Nov 23, 2020
This commit ports the OpenTracing testbed[1] to check that the ot-shim is working as expected using different frameworks. Gevent doesn't support context vars yet[2], so those tests are not compatible with opentelemetry and were not ported. [1] https://github.com/opentracing/opentracing-python/tree/master/testbed [2] gevent/gevent#1407 Co-authored-by: Mauricio Vásquez <[email protected]> Co-authored-by: alrex <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
More and more libraries are switching from
threading.local
tocontextvars.ContextVar
.(So far) gevent does not support
contextvars
. This leads to the situation that libraries need to explicitly check if gevent is used and then select the "old style" implementation. Example: elastic/apm-agent-python@090b938Alternativbely the libraries are not working properly with gevent at all: census-instrumentation/opencensus-python#628
I could find very few information if there is any chance for gevent to support
contextvars
. I found a claim that it is not feasible due to its C implementation. At the same time PEP 550 at least mentioned gevent - in the final 567 this is no more the case though.If it should not be possible some words in the docs would be helpful I think.
The text was updated successfully, but these errors were encountered: