Add pagination info to sections #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
Keats
requested changes
Oct 11, 2024
components/content/src/ser.rs
Outdated
| @@ -162,6 +162,9 @@ pub struct SerializingSection<'a> { | |||
| backlinks: Vec<BackLink<'a>>, | |||
| generate_feeds: bool, | |||
| transparent: bool, | |||
| paginated: bool, | |||
There was a problem hiding this comment.
No need for that one, let's match what is in the frontmatter
There was a problem hiding this comment.
I just removed the unecessary paginated attribute and retrieved raw values from the frontmatter.
Adapted testsite: testsite.zip
`paginated` attributes removed
ZzMzaw
added a commit
to ZzMzaw/zola-theme-tabi
that referenced
this pull request
Oct 11, 2024
Changes have been requested in Zola PR: getzola/zola#2653. This requieres minor adaptation on properties used to reversed pagination.
Keats
approved these changes
Oct 11, 2024
ZzMzaw
added a commit
to ZzMzaw/zola-theme-tabi
that referenced
this pull request
Oct 31, 2024
Changes have been requested in Zola PR: getzola/zola#2653. This requieres minor adaptation on properties used to reversed pagination.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective of this small update is to add some minimal information about pagination in the section itself for cases where the paginator is not available (e.g. when using
get_section).A small site for testing the feature is attached to this PR: testsite.zip.
This feature has been discussed in issue 2473.
Sanity check:
Code changes
(Delete or ignore this section for documentation changes)
nextbranch?If the change is a new feature or adding to/changing an existing one: