Safe Recovery Plugin #96
Conversation
| address public immutable myAddress; | ||
| address private immutable _owner; | ||
| address public immutable myAddress; // Module address | ||
| address private _owner; // Key address |
There was a problem hiding this comment.
I think it may be good to deploy this separately from the Safe so that we can store the safe address here to validate that transactions are coming from the right Safe.
Then we can initialize a variable like
address private immutable safeAddress;
|
|
| // and the plugin are deployed at the same time. So the plugin doesn't know the Safe address. | ||
| emit OWNER_UPDATED(_owner, newOwner); | ||
| _owner = newOwner; | ||
| } |
There was a problem hiding this comment.
Lets make sure the readme is clear with its state of "pre-alpha" and "not for production use" etc.
|
|
||
| bytes memory data = abi.encodeWithSignature("updateOwner(address)", newValidatingEcdsaAddress); | ||
| ISafe(safe).execTransactionFromModule(ecdsaPluginAddress, 0, data, Enum.Operation.Call); | ||
| } |
There was a problem hiding this comment.
Good start, will have to update and add to this, linking other verifications beyond onlyStoredEOA
#71
Adding another plugin that we can use to reset a key for recovery. Right now this is a MVP to work with the ECDSA plugin.
List of changes:
updateOwner()function to the SafeECDSAPlugin.Notes/questions from this work
msg.senderis the safe.