This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
More cleanup for account-integrations/safe #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
JohnGuilding
approved these changes
Sep 18, 2023
| @@ -33,7 +33,6 @@ | |||
| "eslint-plugin-import": "^2.28.1", | |||
| "eslint-plugin-prettier": "^5.0.0", | |||
| "ethers": "^6.4.0", | |||
| "ethers-v5": "npm:[email protected]", | |||
There was a problem hiding this comment.
When I originally copied over these tests and converted them to use ethers v6, I ran into an issue where the bundlerProvider would not work if it wasn't connected to an ethers v5 provider. Hence I added this alias. Did you run into this issue at all? It looks like you just started using ethers v6 for the bundlerProvider with no issues
There was a problem hiding this comment.
Oh interesting. Yeah I didn't run into any trouble, wonder what happened.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent PR
This PR depends on #86. Please merge that PR first.
About
sendUserOpAndWaitsends a user operation and polls for the receiptreceiptOfavoids double await pattern, alleviating the temptation to not wait for the receiptyarn hardhat testis now much faster (not foundry fast, but still).