This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Add compression plugin #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 12, 2023
jzaki
reviewed
Oct 18, 2023
| const userOpCallData = compressionAccount.interface.encodeFunctionData( | ||
| "decompressAndPerform", | ||
| [compressedActions], | ||
| ); |
There was a problem hiding this comment.
Current implementation requires dApps (wallets or SDKs) to be compression-aware and wrap users' functions in decompressAndPerform. For broader use, this can eventually be implemented in an 'aggregator'?
There was a problem hiding this comment.
I think the wallet will always need to be compression-aware, similar to how it needs to be 4337-aware. Compression means that you actually sign a different message, so you can't give control over what message is signed to a third party. However, the same is true for using 4337 itself, so I'm not sure I understand your concern.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #113.
(#113 would originally have included applying this in the in-page wallet as well, but I made that a separate issue that can build on top of this work: #119).