Update misleading and incorrect tests

getwax · Oct 2, 2023 · f19ebfb · f19ebfb
1 parent fd24668
commit f19ebfb
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 24 deletions.
diff --git a/account-integrations/safe/test/forge/SafeBlsPlugin.t.sol b/account-integrations/safe/test/forge/SafeBlsPlugin.t.sol
@@ -23,19 +23,12 @@ contract SafeBlsPluginTest is TestHelper {
         );
     }
 
-    function test_validateNonce_ValidNonceSequence() public {
+    function test_validateNonce_ValidNonce() public view {
         // Arrange
         uint256 nonce = 0;
-        uint192 zeroKey = 0;
 
         // Act & Assert
         safeBlsPlugin.exposed_validateNonce(nonce);
-
-        vm.startPrank(address(safeBlsPlugin));
-        entryPoint.incrementNonce(zeroKey);
-        vm.stopPrank();
-
-        safeBlsPlugin.exposed_validateNonce(nonce++);
     }
 
     function test_validateNonce_ValidNonceLessThanMaxUint64() public view {

diff --git a/account-integrations/safe/test/forge/SafeECDSAPlugin.t.sol b/account-integrations/safe/test/forge/SafeECDSAPlugin.t.sol
@@ -19,19 +19,12 @@ contract SafeECDSAPluginTest is TestHelper {
         safeECDSAPlugin = new SafeECDSAPluginHarness(entryPointAddress);
     }
 
-    function test_validateNonce_ValidNonceSequence() public {
+    function test_validateNonce_ValidNonce() public view {
         // Arrange
         uint256 nonce = 0;
-        uint192 zeroKey = 0;
 
         // Act & Assert
         safeECDSAPlugin.exposedValidateNonce(nonce);
-
-        vm.startPrank(address(safeECDSAPlugin));
-        entryPoint.incrementNonce(zeroKey);
-        vm.stopPrank();
-
-        safeECDSAPlugin.exposedValidateNonce(nonce++);
     }
 
     function test_validateNonce_ValidNonceLessThanMaxUint64() public view {

diff --git a/account-integrations/safe/test/forge/SafeWebAuthnPlugin.t.sol b/account-integrations/safe/test/forge/SafeWebAuthnPlugin.t.sol
@@ -80,19 +80,12 @@ contract SafeWebAuthnPluginTest is TestHelper {
         assertEq(validationData, expectedValidationData);
     }
 
-    function test_validateNonce_ValidNonceSequence() public {
+    function test_validateNonce_ValidNonce() public view {
         // Arrange
         uint256 nonce = 0;
-        uint192 zeroKey = 0;
 
         // Act & Assert
         safeWebAuthnPlugin.exposed_validateNonce(nonce);
-
-        vm.startPrank(address(safeWebAuthnPlugin));
-        entryPoint.incrementNonce(zeroKey);
-        vm.stopPrank();
-
-        safeWebAuthnPlugin.exposed_validateNonce(nonce++);
     }
 
     function test_validateNonce_ValidNonceLessThanMaxUint64() public view {