fix set feature when adding a new root hierarchy
#899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for doing this, I really need this functionality! |
|
This would help alot, not needing to use yq in between |
|
Is there any chance of this being released soon? It is such a problematic bug, and such a simple, well written solution. cc @autrilla maybe? |
|
This is a much needed fix. Thanks! cc @ajvb could you please merge? |
|
@vbehar it has been two years, but I would really like to get this merged to include it in the upcoming release. If you can rebase your PR and sign-off on the commit, I will ensure it gets in :-). |
fixes getsops#407 with this fix, when adding a new root hierarchy, the existing root entries won't be dropped anymore Signed-off-by: Vincent Behar <[email protected]>
hiddeco
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #407
with this fix, when adding a new root hierarchy, the existing root entries won't be dropped anymore