Merge pull request #1124 from stoned/version-no-report-on-error

Do not report version when upstream check fails
getsops · Aug 14, 2023 · cc30d49 · cc30d49
2 parents 408dc02 + cb1a43d
commit cc30d49
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/version/version.go b/version/version.go
@@ -26,11 +26,12 @@ func PrintVersion(c *cli.Context) {
 		outdated, err := AIsNewerThanB(upstreamVersion, Version)
 		if err != nil {
 			out += fmt.Sprintf("\n[warning] failed to compare current version with latest: %v\n", err)
-		}
-		if outdated {
-			out += fmt.Sprintf("\n[info] sops %s is available, update with `go get -u github.com/getsops/sops/v3/cmd/sops`\n", upstreamVersion)
 		} else {
-			out += " (latest)\n"
+			if outdated {
+				out += fmt.Sprintf("\n[info] sops %s is available, update with `go get -u github.com/getsops/sops/v3/cmd/sops`\n", upstreamVersion)
+			} else {
+				out += " (latest)\n"
+			}
 		}
 	}
 	fmt.Fprintf(c.App.Writer, "%s", out)