Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python-zope.hookable: Update to v7.0 #4187

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

python-zope.hookable: Update to v7.0 #4187

wants to merge 1 commit into from
+30 −24

Conversation

androidnisse
Copy link
Contributor

Summary

  • C extension now enables multi-phase module initialization (PEP 489). For CPython >= 3.11, the hookable type is now a heap-allocated type.
  • Drop support for Python 3.7.
  • Add support for Python 3.13.

Test Plan

  • Checked it build correctly.

Checklist

  • Package was built and tested against unstable

Packaging notes

  • Would not build with the tests.

@androidnisse
python-zope.hookable: Update to v7.0
1607fa4 
**Summary**

- C extension now enables multi-phase module initialization (PEP 489). For CPython >= 3.11, the hookable type is now a heap-allocated type.
- Drop support for Python 3.7.
- Add support for Python 3.13.
@davidjharder
Copy link
Member

I suspect the test are failing because tests now require additional packages, one of which is not packaged by solus (zope.testing and zope.testrunner)

https://github.com/zopefoundation/zope.hookable/blob/00be0b33bff21fd5f4a6140f81be841d3c3d3732/setup.py#L82

@androidnisse
Copy link
Contributor Author

I suspect the test are failing because tests now require additional packages, one of which is not packaged by solus (zope.testing and zope.testrunner)

https://github.com/zopefoundation/zope.hookable/blob/00be0b33bff21fd5f4a6140f81be841d3c3d3732/setup.py#L82

So should I add the missing or just let it be without tests?

@davidjharder
Copy link
Member

@joebonrichie could you chime in here

@davidjharder davidjharder mentioned this pull request Oct 31, 2024
Open
@silkeh silkeh added the hacktoberfest-accepted This PR is accepted for Hacktoberfest label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joebonrichie joebonrichie Awaiting requested review from joebonrichie

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
hacktoberfest-accepted This PR is accepted for Hacktoberfest
Projects
Solus
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@androidnisse @davidjharder @silkeh