Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(stats-detectors): Remove unreleased regression issue #409

Merged
merged 3 commits into from
Feb 12, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
- Bump trufflesecurity/trufflehog from 3.67.1 to 3.67.3 ([#404](https://github.com/getsentry/vroom/pull/404))
- Bump pre-commit/action from 3.0.0 to 3.0.1 ([#405](https://github.com/getsentry/vroom/pull/405))
- Bump trufflesecurity/trufflehog from 3.67.3 to 3.67.4 ([#406](https://github.com/getsentry/vroom/pull/406))
- Remove experimental function regression issue ([#409](https://github.com/getsentry/vroom/pull/409))

## 23.12.0

Expand Down
8 changes: 2 additions & 6 deletions internal/occurrence/occurrence.go
Original file line number Diff line number Diff line change
Expand Up @@ -219,12 +219,8 @@ func FromRegressedFunction(
beforeP95 := time.Duration(regressed.AggregateRange1).Round(10 * time.Microsecond)
afterP95 := time.Duration(regressed.AggregateRange2).Round(10 * time.Microsecond)

occurrenceType := FrameRegressionExpType
var issueTitle IssueTitle = "Function Duration Regression (Experimental)"
if regressed.Released {
occurrenceType = FrameRegressionType
issueTitle = "Function Regression"
}
occurrenceType := FrameRegressionType
var issueTitle IssueTitle = "Function Regression"

return &Occurrence{
Culprit: fullyQualifiedName,
Expand Down
17 changes: 0 additions & 17 deletions internal/occurrence/occurrence_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -64,28 +64,11 @@ func TestFromRegressedFunction(t *testing.T) {
Fingerprint: 0,
AggregateRange1: 100_000_000,
AggregateRange2: 200_000_000,
Released: true,
},
expectedType: 2011,
expectedTitle: "Function Regression",
expectedSubtitle: "Duration increased from 100ms to 200ms (P95).",
},
{
name: "unreleased",
frame: f,
function: RegressedFunction{
OrganizationID: 1,
ProjectID: 1,
ProfileID: "",
Fingerprint: 0,
AggregateRange1: 100_000_000,
AggregateRange2: 200_000_000,
Released: false,
},
expectedType: 2010,
expectedTitle: "Function Duration Regression (Experimental)",
expectedSubtitle: "Duration increased from 100ms to 200ms (P95).",
},
}

for _, tt := range tests {
Expand Down
1 change: 0 additions & 1 deletion internal/occurrence/regressed_frame.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ type RegressedFunction struct {
TrendPercentage float64 `json:"trend_percentage"`
UnweightedPValue float64 `json:"unweighted_p_value"`
UnweightedTValue float64 `json:"unweighted_t_value"`
Released bool `json:"released,omitempty"`
}

func ProcessRegressedFunction(
Expand Down
Loading