feat: add support for speedscope rendering of Android reactnative profiles #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
android-reactNative profiles
Zylphrex
reviewed
Jan 10, 2024
frame at index 0 of the stack slice is the leaf frame, wherease frame at the index len(stack slice)-1 is the root frame
Zylphrex
approved these changes
Jan 12, 2024
|
|
||
| // we use the elapsed time since start of the latest sample | ||
| // to exit all the events of the previous one | ||
| closingTimeNs := p.Samples[len(p.Samples)-1].ElapsedSinceStartNS |
There was a problem hiding this comment.
One thing to watch out for here is I'm not sure if you validate the sampled js profile within the react native profile against the guards in relay. For other platforms, we ensure that each thread has at least 1 sample or it will be removed from the profile. Without this guarantee, you can accidentally render an empty profile as the first and last sample will be the same and have the same timestamp.
There was a problem hiding this comment.
There was a problem hiding this comment.
Good point.
Yes, I've double-checked with Pierre and we are validating it in Relay so we're safe to go
https://github.com/getsentry/relay/blob/master/relay-profiling/src/android.rs#L175
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for speedscope rendering of Android ReactNative profiles with mixed android & JS profiles