feat(profiling): Support ingesting mixed android/js profiles for reac…

…t-native (#375) * Support ingesting mixed android/js profiles for react-native
getsentry · Dec 19, 2023 · 03b2f69 · 03b2f69
1 parent e6bb1c1
commit 03b2f69
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 **Features**:
 
 - Return the emitted regressions in response. ([#372](https://github.com/getsentry/vroom/pull/372))
+- Support ingesting mixed android/js profiles for react-native ([#375](https://github.com/getsentry/vroom/pull/375)) --> this will let us store those profiles but it won't render the js part yet. A coming change will support that.
 
 **Internal**:
 
@@ -21,6 +22,8 @@
 
 - Relicense under FSL-1.0-Apache-2.0. ([#366](https://github.com/getsentry/vroom/pull/366))
 
+**Bug Fixes**:
+
 **Internal**:
 
 - Updated craft build rules to no longer bump version after move to FSL license

diff --git a/internal/profile/legacy.go b/internal/profile/legacy.go
@@ -48,6 +48,7 @@ type (
 		OrganizationID       uint64                              `json:"organization_id"`
 		Platform             platform.Platform                   `json:"platform"`
 		Profile              json.RawMessage                     `json:"profile,omitempty"`
+		JsProfile            json.RawMessage                     `json:"js_profile,omitempty"`
 		ProfileID            string                              `json:"profile_id"`
 		ProjectID            uint64                              `json:"project_id"`
 		Received             timeutil.Time                       `json:"received"`

diff --git a/internal/speedscope/speedscope.go b/internal/speedscope/speedscope.go
@@ -123,6 +123,7 @@ type (
 		OrganizationID       uint64                              `json:"organizationID"`                //nolint:unused
 		Platform             platform.Platform                   `json:"platform"`                      //nolint:unused
 		Profile              json.RawMessage                     `json:"-"`                             //nolint:unused
+		JsProfile            json.RawMessage                     `json:"-"`                             //nolint:unused
 		ProfileID            string                              `json:"profileID"`                     //nolint:unused
 		ProjectID            uint64                              `json:"projectID"`                     //nolint:unused
 		Received             timeutil.Time                       `json:"received"`                      //nolint:unused