Merge pull request #489 from getsentry/txiao/fix/do-not-iterate-unclo…

…sed-channel

fix(flamegraphs): Do not iterate unclosed channel

CHANGELOG.md

@@ -30,6 +30,7 @@
 - Reuse one http client across different requests ([#458](https://github.com/getsentry/vroom/pull/458))
 - Fix correct in_app classification for `[Native]` js frames ([#464](https://github.com/getsentry/vroom/pull/464))
 - Ignore react-native js frame for metrics aggregation when not symbolicated ([#465](https://github.com/getsentry/vroom/pull/465))
+- Do not iterate unclosed channel ([#489](https://github.com/getsentry/vroom/pull/489))
 
 **Internal**:
 

internal/flamegraph/flamegraph.go

@@ -424,7 +424,9 @@ func GetFlamegraphFromCandidates(
 ) (speedscope.Output, error) {
 	hub := sentry.GetHubFromContext(ctx)
 
-	results := make(chan storageutil.ReadJobResult, len(transactionProfileCandidates)+len(transactionProfileCandidates))
+	numCandidates := len(transactionProfileCandidates) + len(continuousProfileCandidates)
+
+	results := make(chan storageutil.ReadJobResult, numCandidates)
 	defer close(results)
 
 	for _, candidate := range transactionProfileCandidates {
@@ -454,7 +456,9 @@ func GetFlamegraphFromCandidates(
 
 	var flamegraphTree []*nodetree.Node
 
-	for res := range results {
+	for i := 0; i < numCandidates; i++ {
+		res := <-results
+
 		err := res.Error()
 		if err != nil {
 			if errors.Is(err, storageutil.ErrObjectNotFound) {