-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@spotlightjs/astro: Fix importing arbitrary paths on Windows #276
Conversation
@66Leo66 is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @66Leo66 thanks for opening this PR! I saw your issue and PR comment in the Astro repo. I believe that once we merge and release this fix as well as Astro resolves things on their end we should be good, correct?
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
=======================================
Coverage 32.42% 32.42%
=======================================
Files 45 45
Lines 2091 2091
Branches 71 71
=======================================
Hits 678 678
Misses 1413 1413 ☔ View full report in Codecov by Sentry. |
Yeah, as in withastro/astro#9400 (comment), applying fix to both side should resolve the problem. |
Thanks, we'll cut a release on Monday! |
Before opening this PR:
pnpm changeset:add
Changes
Use
JSON.stringify
when injecting arbitrary paths so it works on Windows (backslashes wont cause problems)Related
Fix withastro/astro#9389
Astro's fix PR withastro/astro#9400
Notes
Spotlight's Astro integration, for some reason, does its own import via vite while registering another import via Astro's Dev Toolbar API. Unfortunately both have the same issue related to absolute path and
\
on Windows. This PR fixes the former while withastro/astro#9400 fixes the latter(not yet landed).JSON.stringify
is used in the fix as well as withastro/astro#9400 .