-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(replay): viewed_by_id migration #5706
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update group_loader.py
.
This PR has a migration; here is the generated SQL -- start migrations
-- forward migration replays : 0018_add_viewed_by_id_column
Local op: ALTER TABLE replays_local ADD COLUMN IF NOT EXISTS viewed_by_id UInt64 AFTER user_email;
Distributed op: ALTER TABLE replays_dist ADD COLUMN IF NOT EXISTS viewed_by_id UInt64 AFTER user_email;
-- end forward migration replays : 0018_add_viewed_by_id_column
-- backward migration replays : 0018_add_viewed_by_id_column
Distributed op: ALTER TABLE replays_dist DROP COLUMN IF EXISTS viewed_by_id;
Local op: ALTER TABLE replays_local DROP COLUMN IF EXISTS viewed_by_id;
-- end backward migration replays : 0018_add_viewed_by_id_column |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## master #5706 +/- ##
==========================================
+ Coverage 89.86% 89.87% +0.01%
==========================================
Files 900 901 +1
Lines 43770 43781 +11
Branches 301 301
==========================================
+ Hits 39332 39350 +18
+ Misses 4396 4389 -7
Partials 42 42 ☔ View full report in Codecov by Sentry. |
|
||
|
||
columns: List[Tuple[str, Column[Modifiers]]] = [ | ||
("user_email", Column("viewed_by_id", UInt(64))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does user_email
have to do with anything here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the column that it comes after
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the boilerplate we used in 0017
This looks good to me. You can make the check pass by moving the yaml changes into a different PR. This makes sure the column will be there before we start being able to query it |
…sentry/snuba into aliu/viewed-replay-migration
yaml changes moved to #5709 |
Relates to getsentry/sentry#64924