ref: Use message.position_to_commit from arroyo #3246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies getting the right position to commit from Arroyo. Also fixes a bug where the wrong offset was being committed on shutdown (it should be message.next_offset but we were actually committing message.offset)
Codecov ReportBase: 92.31% // Head: 92.31% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3246 +/- ##
=======================================
Coverage 92.31% 92.31%
=======================================
Files 699 699
Lines 31677 31677
=======================================
+ Hits 29242 29243 +1
+ Misses 2435 2434 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
evanh
approved these changes
Oct 13, 2022
enochtangg
pushed a commit
that referenced
this pull request
Oct 17, 2022
This simplifies getting the right position to commit from Arroyo. Also fixes a bug where the wrong offset was being committed on shutdown (it should be message.next_offset but we were actually committing message.offset)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies getting the right position to commit from Arroyo. Also fixes a bug where the wrong offset was being committed on shutdown (it should be message.next_offset but we were actually committing message.offset)