-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(devservices): Add option to setup sentry with new devservices to existing action #83415
feat(devservices): Add option to setup sentry with new devservices to existing action #83415
Conversation
shouldn't we just convert the existing action to use devservices instead? |
We should, but the existing action is used in snuba/relay/symbolicator for sentry integration tests. Adding this new action will allow a smoother cutover where we can ensure that the new action is working for those repos before we can go ahead and remove the existing action entirely. Also, we can ensure that we don't completely break CI in those other repos while converting the existing action to use new devservices |
the separate action makes it really difficult to see what's different with the currently used action -- I remember the cron job having a bug with MATRIX_INSTANCE for instance would it be possible to unify the two via an option and then we'd just delete the option later? |
good point, can go down that path instead |
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested this option in 4039e58, looks good to go |
This adds an option to use new devservices to the setup-sentry action