Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devservices): Add option to setup sentry with new devservices to existing action #83415

Merged

Conversation

hubertdeng123
Copy link
Member

@hubertdeng123 hubertdeng123 commented Jan 14, 2025

This adds an option to use new devservices to the setup-sentry action

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 14, 2025
@hubertdeng123
Copy link
Member Author

@hubertdeng123 hubertdeng123 marked this pull request as ready for review January 14, 2025 20:43
@hubertdeng123 hubertdeng123 requested a review from a team as a code owner January 14, 2025 20:43
@asottile-sentry
Copy link
Member

shouldn't we just convert the existing action to use devservices instead?

@hubertdeng123
Copy link
Member Author

hubertdeng123 commented Jan 14, 2025

shouldn't we just convert the existing action to use devservices instead?

We should, but the existing action is used in snuba/relay/symbolicator for sentry integration tests. Adding this new action will allow a smoother cutover where we can ensure that the new action is working for those repos before we can go ahead and remove the existing action entirely.

Also, we can ensure that we don't completely break CI in those other repos while converting the existing action to use new devservices

@asottile-sentry
Copy link
Member

shouldn't we just convert the existing action to use devservices instead?

We should, but the existing action is used in snuba/relay/symbolicator for sentry integration tests. Adding this new action will allow a smoother cutover where we can ensure that the new action is working for those repos before we can go ahead and remove the existing action entirely.

Also, we can ensure that we don't completely break CI in those other repos while converting the existing action to use new devservices

the separate action makes it really difficult to see what's different with the currently used action -- I remember the cron job having a bug with MATRIX_INSTANCE for instance

would it be possible to unify the two via an option and then we'd just delete the option later?

@hubertdeng123
Copy link
Member Author

would it be possible to unify the two via an option and then we'd just delete the option later?

good point, can go down that path instead

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 14, 2025
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the docker ps -a is sometimes useful

@hubertdeng123
Copy link
Member Author

tested this option in 4039e58, looks good to go

@hubertdeng123 hubertdeng123 changed the title feat(devservices): Add new action to setup sentry with new devservices feat(devservices): Add option to setup sentry with new devservices to existing action Jan 14, 2025
@hubertdeng123 hubertdeng123 merged commit d4c7154 into master Jan 14, 2025
49 checks passed
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/add-setup-sentry-new-devservices-action branch January 14, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants