ref(aci): pass WorkflowJob into process_workflows #82489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
cathteng
commented
Dec 20, 2024
Comment on lines
+1006
to
+1015
| # PostProcessJob event is optional, WorkflowJob event is required | ||
| if "event" not in job: | ||
| logger.error("Missing event to create WorkflowJob", extra={"job": job}) | ||
| return | ||
|
|
||
| try: | ||
| workflow_job = WorkflowJob({**job}) # type: ignore[typeddict-item] | ||
| except Exception: | ||
| logger.exception("Could not create WorkflowJob", extra={"job": job}) | ||
| return |
There was a problem hiding this comment.
couldn't make mypy happy with this, it kept complaining the event didn't exist
cathteng
commented
Dec 20, 2024
Comment on lines
+32
to
+43
| class EventJob(TypedDict): | ||
| event: GroupEvent | ||
|
|
||
|
|
||
| class WorkflowJob(EventJob, total=False): | ||
| group_state: GroupState | ||
| is_reprocessed: bool | ||
| has_reappeared: bool | ||
| has_alert: bool | ||
| has_escalated: bool | ||
|
|
||
|
|
There was a problem hiding this comment.
the main piece of this PR
ceorourke
reviewed
Dec 20, 2024
| if state is None: | ||
| return False | ||
|
|
||
| return state["is_regression"] == comparison |
There was a problem hiding this comment.
is is_regression guaranteed to exist on state? if not I'd do a .get()
There was a problem hiding this comment.
yes it's guaranteed, the state is a typed dict too
sentry/src/sentry/eventstream/base.py
Lines 30 to 34 in a62dc3b
ceorourke
approved these changes
Dec 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR #82096
process_workflowsis currently called with aGroupEventfor issue types like metric issues to fire downstream actions.To process issue alerts, we use other elements of
PostProcessJobinpost_processto evaluate conditions. As such, we should pass a version ofPostProcessJob(here calledWorkflowJob) intoprocess_workflows. It contains a requiredGroupEventand then makes everything else fromPostProcessJoboptional.