feat(api): Support security interfaces fully #8213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Expose ExpectCT, ExpectStaple, and HPKP in UI - Correct hashing on ExpectCT, ExpectStaple, and HPKP to include type - Add support for ExpectCT and HPKP samples - Add bin/mock-event helper
|
Stream
Details
|
dcramer
commented
Apr 26, 2018
| @@ -5,7 +5,14 @@ import {Metadata} from '../proptypes'; | |||
| class EventOrGroupTitle extends React.Component { | |||
| static propTypes = { | |||
| data: PropTypes.shape({ | |||
| type: PropTypes.oneOf(['error', 'csp', 'default']).isRequired, | |||
| type: PropTypes.oneOf([ | |||
There was a problem hiding this comment.
kind of painful maintaining these like this, but we can refactor in the future
There was a problem hiding this comment.
yeah we can move this into our types module later on
billyvg
reviewed
Apr 26, 2018
| case 'raw': | ||
| return <pre>{JSON.stringify({'csp-report': data}, null, 2)}</pre>; | ||
| default: | ||
| throw new TypeError(`Invalid view: ${view}`); |
There was a problem hiding this comment.
Does this component's parent have an ErrorBoundary?
There was a problem hiding this comment.
Dont think so but htis is the same way CSP works.
I was thinking about how we should just create an 'Interface' base component that all of these extend. It'd make life a lot easier and we could enforce some behavior a bit better.
billyvg
approved these changes
Apr 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH-5133