feat(widget-builder): Add limit field to widget builder hook #81944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
narsaynorath
approved these changes
Dec 11, 2024
| }) | ||
| ); | ||
|
|
||
| const {result} = renderHook(() => useWidgetBuilderState()); |
There was a problem hiding this comment.
I think this is failing because you need to add a second argument to render hook since now I'm tying it to the URL batch thing.
Suggested change
| const {result} = renderHook(() => useWidgetBuilderState()); | |
| const {result} = renderHook(() => useWidgetBuilderState(), {wrapper: <whatever I called the provider>}); |
There was a problem hiding this comment.
yup yup just added that in
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 2, 2025
Added the limit field to widget builder hook and made test. I put it as a number and use a deserializer to go from query param string to number. Let me know if there was a different way you were thinking of doing it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the limit field to widget builder hook and made test. I put it as a number and use a deserializer to go from query param string to number. Let me know if there was a different way you were thinking of doing it.